Add removed property to Log type
#4877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdevcs
reviewed
Mar 30, 2022
added this upon jdevcs' [request](web3#4877 (comment))
nazarhussain
approved these changes
Apr 3, 2022
Pull Request Test Coverage Report for Build 2161428870
💛 - Coveralls |
avkos
approved these changes
May 4, 2022
|
This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
jdevcs
added
Future Release
jdevcs
changed the base branch from
1.x
to
junaid/removedpropertytologtypee2etest
31 tasks
|
Merged into 1.x via #5576 |
jdevcs
added a commit
that referenced
this pull request
Oct 28, 2022
* Add `removed` property to `Log` type Fixes #4747 (comment) * Update CHANGELOG.md added this upon jdevcs' [request](#4877 (comment)) * Update CHANGELOG.md Co-authored-by: Junaid <[email protected]> Co-authored-by: Samuel Laferriere <[email protected]>
Merged
This was referenced Mar 3, 2023
This was referenced Mar 3, 2023
This was referenced Mar 7, 2023
This was referenced Mar 7, 2023
This was referenced Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at Fixing #4747 (comment)
This is just trying to move forward in fixing this issue. I don't have the time to deep dive into web3js and try to understand how to make sure that this PR is non-breaking, so would like for someone else to help me verify.
I just added the property and ran
tsc --noEmitinpackages/web3-corewhich type checked.However I am not sure if it breaks some of the other web3 packages, since when running
tsc --noEmitin the root folder, I get a gazillion type errors from the tests, such aswhich comes from
Perhaps we could add
// @ts-ignoreabove these lines, but I'm not sure if it wouldn't break the// $ExpectErrorcommands (maybe only the line before the actual test applies?).